Skip to content

Conversation

@nija-at
Copy link
Contributor

@nija-at nija-at commented Oct 14, 2021

A previous commit - 0fb2179 - removed the need for vendoring in the old
assert module. It had previously required its dependencies to be
bundled.

These dependencies are no longer required. This clean up was missed in
the previous commit.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

A previous commit - 0fb2179 - removed the need for vendoring in the old
assert module. It had previously required its dependencies to be
bundled.

These dependencies are no longer required. This clean up was missed in
the previous commit.
@nija-at nija-at requested review from a team and kaizencc October 14, 2021 06:57
@nija-at nija-at self-assigned this Oct 14, 2021
@gitpod-io
Copy link

gitpod-io bot commented Oct 14, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 14, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Oct 27, 2021

monocdk: � An error occurred:  Error: Fixed dependency inconsistencies. Commit the updated package.json file.

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 08eea3a
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 39ee7e9 into master Nov 9, 2021
@mergify mergify bot deleted the nija-at/assertions-cleanup-bundled branch November 9, 2021 12:37
@mergify
Copy link
Contributor

mergify bot commented Nov 9, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
A previous commit - 0fb2179 - removed the need for vendoring in the old
assert module. It had previously required its dependencies to be
bundled.

These dependencies are no longer required. This clean up was missed in
the previous commit.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants