-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: increase vm.max_map_count to (hopefully) mitigate OOM errors #16752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared to our max threads (1125977). Based on a NodeJS issue troubleshooting thread (nodejs/help#2809), trying to see if increasing this value stabilizes our builds.
RomainMuller
suggested changes
Oct 1, 2021
RomainMuller
approved these changes
Oct 1, 2021
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
njlynch
added a commit
that referenced
this pull request
Oct 1, 2021
This value was reduced as part of troubleshooting of various Node Worker memory issues. These issues are theorized to have been mitigated by #16752. Our pack time is currently over 2 hours, compared to 20-30 minutes prior to the set of changes. By removing this worker count override, we should be able to get back to normal pack times and speed up the pipeline.
mergify bot
pushed a commit
that referenced
this pull request
Oct 1, 2021
This value was reduced as part of troubleshooting of various Node Worker memory issues. These issues are theorized to have been mitigated by #16752. Our pack time is currently over 2 hours, compared to 20-30 minutes prior to the set of changes. By removing this worker count override, we should be able to get back to normal pack times and speed up the pipeline. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
added a commit
that referenced
this pull request
Oct 11, 2021
…16752) The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared to our max threads (1125977). Based on a NodeJS issue troubleshooting thread (nodejs/help#2809), trying to see if increasing this value stabilizes our builds. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch
added a commit
that referenced
this pull request
Oct 11, 2021
This value was reduced as part of troubleshooting of various Node Worker memory issues. These issues are theorized to have been mitigated by #16752. Our pack time is currently over 2 hours, compared to 20-30 minutes prior to the set of changes. By removing this worker count override, we should be able to get back to normal pack times and speed up the pipeline. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
…ws#16752) The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared to our max threads (1125977). Based on a NodeJS issue troubleshooting thread (nodejs/help#2809), trying to see if increasing this value stabilizes our builds. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
This value was reduced as part of troubleshooting of various Node Worker memory issues. These issues are theorized to have been mitigated by aws#16752. Our pack time is currently over 2 hours, compared to 20-30 minutes prior to the set of changes. By removing this worker count override, we should be able to get back to normal pack times and speed up the pipeline. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The vm.max_map_count on our CodeBuild instances is fairly low (65530) compared
to our max threads (1125977). Based on a NodeJS issue troubleshooting thread
(nodejs/help#2809), trying to see if increasing this
value stabilizes our builds.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license