Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(route53-targets): ApiGateway does not accept RestApiBase #16610

Merged
merged 2 commits into from
Sep 23, 2021
Merged

fix(route53-targets): ApiGateway does not accept RestApiBase #16610

merged 2 commits into from
Sep 23, 2021

Conversation

kaizencc
Copy link
Contributor

Closes #16227.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Sep 22, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 22, 2021
@kaizencc kaizencc requested a review from njlynch September 22, 2021 22:33
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up!

@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 9c61e00
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 20071bb into aws:master Sep 23, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 23, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@kaizencc kaizencc deleted the r53targets branch September 23, 2021 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-route53-targets): Cannot use SpecRestApi to create ApiGateway target for ARecord
3 participants