feat(ec2): add aspect to require imdsv2#16051
Merged
mergify[bot] merged 4 commits intoaws:masterfrom Oct 20, 2021
Merged
Conversation
|
|
jericht
force-pushed
the
jericht/ec2_imdsv1_aspect
branch
2 times, most recently
from
4e39bd4 to
d95bbae
Compare
peterwoodworth
added
effort/small
jericht
force-pushed
the
jericht/ec2_imdsv1_aspect
branch
from
d95bbae to
75c9920
Compare
Contributor
Author
|
@njlynch I've rebased these changes and they are ready for review. Would you be able to take a look? |
jericht
force-pushed
the
jericht/ec2_imdsv1_aspect
branch
from
75c9920 to
13c311c
Compare
RomainMuller
force-pushed
the
master
branch
from
924c117 to
ebfd5f2
Compare
rix0rrr
previously requested changes
Oct 19, 2021
Contributor
rix0rrr
left a comment
rix0rrr
left a comment
There was a problem hiding this comment.
I don't mind the code duplication, but I would appreciate naming consistency. Let's name it requireImdsv2 here as well.
mergify bot
pushed a commit
that referenced
this pull request
Oct 19, 2021
Partially fixes: #5137 Related PR: #16051 **Note:** I have some concerns about duplicated code between this and the above linked PR. Please see that PR for more details. ### Changes Adds an aspect that can enable/disable IMDSv1 on AutoScalingGroups ### Testing Added unit tests ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
jericht
force-pushed
the
jericht/ec2_imdsv1_aspect
branch
from
13c311c to
6d95697
Compare
rix0rrr
approved these changes
Oct 20, 2021
rix0rrr
changed the title
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Partially fixes: aws#5137 Related PR: aws#16051 **Note:** I have some concerns about duplicated code between this and the above linked PR. Please see that PR for more details. ### Changes Adds an aspect that can enable/disable IMDSv1 on AutoScalingGroups ### Testing Added unit tests ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this pull request
Feb 21, 2022
Partially fixes: aws#5137 Related PR: aws#16052 **Note:** This PR and the above related PR have common code that has been duplicated across these two PRs because I decided it made more sense for these Aspects to be in the same package with the constructs they work with. However, it means I had to duplicate some of the base class code across the two PRs. Looking for an opinion on what's better here: - Should we keep it as is (2 PRs) so these Aspects are cleanly separated? or, - Does it make sense to either combine them in some way (e.g. a new package `@aws-cdk/aspects`) or have one reference the other (maybe the AutoScalingGroup aspect can reference the code in this PR since it already depends on this package). ### Changes Adds an aspect that can enable/disable IMDSv1 on Instances and Launch Templates. ### Testing Added unit tests ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes: #5137
Related PR: #16052
Note: This PR and the above related PR have common code that has been duplicated across these two PRs because I decided it made more sense for these Aspects to be in the same package with the constructs they work with. However, it means I had to duplicate some of the base class code across the two PRs. Looking for an opinion on what's better here:
@aws-cdk/aspects) or have one reference the other (maybe the AutoScalingGroup aspect can reference the code in this PR since it already depends on this package).Changes
Adds an aspect that can enable/disable IMDSv1 on Instances and Launch Templates.
Testing
Added unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license