Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sns): add sns service trust to keys for encrypted queue subscriptions #14960

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Jun 2, 2021

Add SNS service trust to KMS key when creating an SNS subscription for an encrypted SQS queue.

Closes #2504

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jun 2, 2021

@rrhodes rrhodes changed the title add sns service trust to keys for encrypted queue subscriptions feat(sns): add sns service trust to keys for encrypted queue subscriptions Jun 2, 2021
@peterwoodworth peterwoodworth added the @aws-cdk/aws-sns Related to Amazon Simple Notification Service label Jun 3, 2021
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e9c2934
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit ccc2e30 into aws:master Jun 24, 2021
@mergify
Copy link
Contributor

mergify bot commented Jun 24, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…tions (aws#14960)

Add SNS service trust to KMS key when creating an SNS subscription for an encrypted SQS queue.

Closes aws#2504
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sns Related to Amazon Simple Notification Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sns] add sns service trust to key when subscribing to an encrypted queue
4 participants