Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ export abstract class BaseLoadBalancer extends cdk.Construct implements route53.
this.vpc = baseProps.vpc;

const resource = new CfnLoadBalancer(this, 'Resource', {
loadBalancerName: baseProps.loadBalancerName,
name: baseProps.loadBalancerName,
subnets: subnets.map(s => s.subnetId),
scheme: internetFacing ? 'internet-facing' : 'internal',
loadBalancerAttributes: new cdk.Token(() => renderAttributes(this.attributes)),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { expect, haveResource, ResourcePart } from '@aws-cdk/assert';
import ec2 = require('@aws-cdk/aws-ec2');
import s3 = require('@aws-cdk/aws-s3');
import cdk = require('@aws-cdk/cdk');
import { Stack } from '@aws-cdk/cdk';
import { Test } from 'nodeunit';
import elbv2 = require('../../lib');

Expand Down Expand Up @@ -186,4 +187,22 @@ export = {

test.done();
},

'loadBalancerName'(test: Test) {
// GIVEN
const stack = new Stack();
const vpc = new ec2.VpcNetwork(stack, 'Stack');

// WHEN
new elbv2.ApplicationLoadBalancer(stack, 'ALB', {
loadBalancerName: 'myLoadBalancer',
vpc
});

// THEN
expect(stack).to(haveResource('AWS::ElasticLoadBalancingV2::LoadBalancer', {
Name: 'myLoadBalancer'
}));
test.done();
},
};
Original file line number Diff line number Diff line change
Expand Up @@ -75,4 +75,23 @@ export = {

test.done();
},

'loadBalancerName'(test: Test) {
// GIVEN
const stack = new cdk.Stack();
const vpc = new ec2.VpcNetwork(stack, 'Stack');

// WHEN
new elbv2.NetworkLoadBalancer(stack, 'ALB', {
loadBalancerName: 'myLoadBalancer',
vpc
});

// THEN
expect(stack).to(haveResource('AWS::ElasticLoadBalancingV2::LoadBalancer', {
Name: 'myLoadBalancer'
}));
test.done();
}

};