Skip to content

fix(cli): broken java init template #13988

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Apr 6, 2021
Merged

fix(cli): broken java init template #13988

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9186f13
fix(cli): broken java init template
MrArnoldPalmer Apr 6, 2021
b8c8e70
Make comments cleaner
MrArnoldPalmer Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 20 additions & 14 deletions ...ib/init-templates/v1/app/java/src/main/java/com/myorg/%name.PascalCased%App.template.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,38 +2,44 @@

import software.amazon.awscdk.core.App;
import software.amazon.awscdk.core.Environment;
import software.amazon.awscdk.core.StackProps;

import java.util.Arrays;

public class %name.PascalCased%App {
public static void main(final String[] args) {
App app = new App();

%name.PascalCased%Stack.Builder.create(app, "%name.PascalCased%Stack")
// If you don't specify 'env', this stack will be environment-agnostic.
// Account/Region-dependent features and context lookups will not work,
// but a single synthesized template can be deployed anywhere.
// If you don't specify 'env', this stack will be environment-agnostic.
// Account/Region-dependent features and context lookups will not work,
// but a single synthesized template can be deployed anywhere.
new %name.PascalCased%Stack(app, "%name.PascalCased%Stack");

// Uncomment the next block to specialize this stack for the AWS Account
// and Region that are implied by the current CLI configuration.
/*
// Replace the above stack intialization with the following to specialize
// this stack for the AWS Account and Region that are implied by the current
// CLI configuration.
/*
new %name.PascalCased%Stack(app, "%name.PascalCased%Stack", StackProps.builder()
.env(Environment.builder()
.account(System.getenv("CDK_DEFAULT_ACCOUNT"))
.region(System.getenv("CDK_DEFAULT_REGION"))
.build())
*/
.build());
*/

// Uncomment the next block if you know exactly what Account and Region you
// want to deploy the stack to.
/*
// Replace the above stack initialization with the following if you know exactly
// what Account and Region you want to deploy the stack to.
/*
new %name.PascalCased%Stack(app, "%name.PascalCased%Stack", StackProps.builder()
.env(Environment.builder()
.account("123456789012")
.region("us-east-1")
.build())
*/

// For more information, see https://docs.aws.amazon.com/cdk/latest/guide/environments.html
.build();
.build());
*/

// For more information, see https://docs.aws.amazon.com/cdk/latest/guide/environments.html

app.synth();
}
Expand Down
35 changes: 20 additions & 15 deletions ...ib/init-templates/v2/app/java/src/main/java/com/myorg/%name.PascalCased%App.template.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,31 +9,36 @@ public class %name.PascalCased%App {
public static void main(final String[] args) {
App app = new App();

%name.PascalCased%Stack.Builder.create(app, "%name.PascalCased%Stack")
// If you don't specify 'env', this stack will be environment-agnostic.
// Account/Region-dependent features and context lookups will not work,
// but a single synthesized template can be deployed anywhere.

// Uncomment the next block to specialize this stack for the AWS Account
// and Region that are implied by the current CLI configuration.
/*
// If you don't specify 'env', this stack will be environment-agnostic.
// Account/Region-dependent features and context lookups will not work,
// but a single synthesized template can be deployed anywhere.
new %name.PascalCased%Stack(app, "%name.PascalCased%Stack");

// Replace the above stack intialization with the following to specialize
// this stack for the AWS Account and Region that are implied by the current
// CLI configuration.
/*
new %name.PascalCased%Stack(app, "%name.PascalCased%Stack", StackProps.builder()
.env(Environment.builder()
.account(System.getenv("CDK_DEFAULT_ACCOUNT"))
.region(System.getenv("CDK_DEFAULT_REGION"))
.build())
*/
.build());
*/

// Uncomment the next block if you know exactly what Account and Region you
// want to deploy the stack to.
/*
// Replace the above stack initialization with the following if you know exactly
// what Account and Region you want to deploy the stack to.
/*
new %name.PascalCased%Stack(app, "%name.PascalCased%Stack", StackProps.builder()
.env(Environment.builder()
.account("123456789012")
.region("us-east-1")
.build())
*/

// For more information, see https://docs.aws.amazon.com/cdk/latest/guide/environments.html
.build();
.build());
*/

// For more information, see https://docs.aws.amazon.com/cdk/latest/guide/environments.html

app.synth();
}
Expand Down