feat(elasticsearch): graduate to stable 🚀 #13900
Conversation
|
|
github-actions
bot
added
the
@aws-cdk/aws-elasticsearch
|
|
||
| expect(() => new Domain(stack, 'Domain1', { | ||
| version: ElasticsearchVersion.V7_4, | ||
| vpcOptions: { |
There was a problem hiding this comment.
This whole config wasn't really needed to assert the test, which validates the availabilityZoneCount property below.
| test('error when availabilityZoneCount does not match vpcOptions.subnets length', () => { | ||
| const vpc = new Vpc(stack, 'Vpc'); | ||
| const vpc = new Vpc(stack, 'Vpc', { | ||
| maxAzs: 1, |
There was a problem hiding this comment.
Simpler way to enforce a single AZ.
| * @default maximum over 1 minute | ||
| */ | ||
| metricClusterIndexWriteBlocked(props?: MetricOptions): Metric; | ||
| metricClusterIndexWritesBlocked(props?: MetricOptions): Metric; |
There was a problem hiding this comment.
|
Forgot to actually bump the stability |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR includes a last minute API change that standardizes the way VPC configuration is passed to the domain. It also provides sane defaults, enabling users to simply pass `vpc` in order to connect a domain to a VPC. In addition, I added a missing integration test for VPC enabled domains. Resolves aws#10965 BREAKING CHANGE: `vpcOptions` was removed. Use `vpc`, `vpcSubnets` and `securityGroups` instead. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
3 participants
This PR includes a last minute API change that standardizes the way VPC configuration is passed to the domain. It also provides sane defaults, enabling users to simply pass
vpcin order to connect a domain to a VPC.In addition, I added a missing integration test for VPC enabled domains.
Resolves #10965
BREAKING CHANGE:
vpcOptionswas removed. Usevpc,vpcSubnetsandsecurityGroupsinstead.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license