chore: un-jsii and bundle @aws-cdk/yaml-cfn
#13699
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `yaml-cfn` library is used as an implementation detail of `cloudformation-include`, `aws-cdk`, `decdk`, and the monopackages. Un-jsii it and bundle it into the framework packages that need it. Does not need to be accessed over jsii and does not need to be exposed in the monopackages.
|
|
NetaNir
approved these changes
Mar 19, 2021
nija-at
approved these changes
Mar 23, 2021
Comment on lines
-29
to
-48
| "java": { | ||
| "package": "software.amazon.awscdk.yaml.cfn", | ||
| "maven": { | ||
| "groupId": "software.amazon.awscdk", | ||
| "artifactId": "cdk-yaml-cfn" | ||
| } | ||
| }, | ||
| "dotnet": { | ||
| "namespace": "Amazon.CDK.Yaml.Cfn", | ||
| "packageId": "Amazon.CDK.Yaml.Cfn", | ||
| "iconUrl": "https://raw.githubusercontent.com/aws/aws-cdk/master/logo/default-256-dark.png" | ||
| }, | ||
| "python": { | ||
| "distName": "aws-cdk.yaml-cfn", | ||
| "module": "aws_cdk.yaml_cfn", | ||
| "classifiers": [ | ||
| "Framework :: AWS CDK", | ||
| "Framework :: AWS CDK :: 1" | ||
| ] | ||
| } |
Contributor
There was a problem hiding this comment.
Do we need to manually deprecate this pkg in all non-npm package managers?
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Mar 24, 2021
The `yaml-cfn` library is used as an implementation detail of `cloudformation-include`, `aws-cdk`, `decdk`, and the monopackages. Un-jsii it and bundle it into the framework packages that need it. Does not need to be accessed over jsii and does not need to be exposed in the monopackages. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
rix0rrr
added a commit
that referenced
this pull request
Apr 1, 2021
The `yaml-cfn` library is used as an implementation detail of `cloudformation-include`, `aws-cdk`, `decdk`, and the monopackages. Un-jsii it and bundle it into the framework packages that need it. Does not need to be accessed over jsii and does not need to be exposed in the monopackages. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot
pushed a commit
that referenced
this pull request
Apr 6, 2021
The `yaml-cfn` library is used as an implementation detail of `cloudformation-include`, `aws-cdk`, `decdk`, and the monopackages. Un-jsii it and bundle it into the framework packages that need it. Does not need to be accessed over jsii and does not need to be exposed in the monopackages. ---- The previous version of this PR (#13699) had to be reverted (b1ffd33), because of a bug in NPM that causes `.npmignore` files in symlinked, bundled dependencies to be ignored. This in turn caused undesired `.ts` files to be bundled, which caused `ts-node` to exit with an error. Introduce a new `cdk-postpack` tool which will strip files that NPM *should* have ignored from the generated tarball, and add some verification to the `pack.sh` script to make sure we don't accidentally bundle `.ts` files. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
The `yaml-cfn` library is used as an implementation detail of `cloudformation-include`, `aws-cdk`, `decdk`, and the monopackages. Un-jsii it and bundle it into the framework packages that need it. Does not need to be accessed over jsii and does not need to be exposed in the monopackages. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
The `yaml-cfn` library is used as an implementation detail of `cloudformation-include`, `aws-cdk`, `decdk`, and the monopackages. Un-jsii it and bundle it into the framework packages that need it. Does not need to be accessed over jsii and does not need to be exposed in the monopackages. ---- The previous version of this PR (aws#13699) had to be reverted (aws@b1ffd33), because of a bug in NPM that causes `.npmignore` files in symlinked, bundled dependencies to be ignored. This in turn caused undesired `.ts` files to be bundled, which caused `ts-node` to exit with an error. Introduce a new `cdk-postpack` tool which will strip files that NPM *should* have ignored from the generated tarball, and add some verification to the `pack.sh` script to make sure we don't accidentally bundle `.ts` files. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
yaml-cfnlibrary is used as an implementation detail ofcloudformation-include,aws-cdk,decdk, and the monopackages.Un-jsii it and bundle it into the framework packages that need it.
Does not need to be accessed over jsii and does not need to be exposed
in the monopackages.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license