Skip to content

Conversation

@rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Mar 19, 2021

NPM6 can apparently not correctly process a package-lock generated using NPM7.

This will crop up more and more as NPM 7 starts becoming more popular; add a documentation
section about this.

Fixes #13666.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

NPM6 can apparently not correctly process a package-lock generated using NPM7.

This will crop up more and more as NPM 7 starts becoming more popular; add a documentation
section about this.

Fixes #13666.
@rix0rrr rix0rrr requested a review from a team March 19, 2021 10:45
@rix0rrr rix0rrr self-assigned this Mar 19, 2021
@gitpod-io
Copy link

gitpod-io bot commented Mar 19, 2021

@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Mar 19, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 19, 2021
The stack failed its previous deployment, and is in a non-retryable state.
Go into the CloudFormation console, delete the stack, and retry the deployment.

### Cannot find module 'xxxx' or its corresponding type declarations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't sound isolated to CDK pipelines.

Should this go here instead? https://docs.aws.amazon.com/cdk/latest/guide/troubleshooting.html

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not strictly "isolated to", no.

But I predict it will be more prevalent in CDK pipelines because the CodeBuild environment is less strictly controlled by users (it's a default image provided by CodeBuild).

Still makes sense to put it close to where people are likely to encounter it.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: eee1803
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit aa45ede into master Mar 19, 2021
@mergify mergify bot deleted the rix0rrr-patch-1 branch March 19, 2021 16:52
eladb pushed a commit that referenced this pull request Mar 24, 2021
NPM6 can apparently not correctly process a package-lock generated using NPM7.

This will crop up more and more as NPM 7 starts becoming more popular; add a documentation
section about this.

Fixes #13666.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
NPM6 can apparently not correctly process a package-lock generated using NPM7.

This will crop up more and more as NPM 7 starts becoming more popular; add a documentation
section about this.

Fixes aws#13666.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/pipelines CDK Pipelines library contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[cdk-pipelines]: Typescript pipeline fails with module missing errors on code build

3 participants