Skip to content

Conversation

@maoshouse
Copy link
Contributor

The id in the example was misnamed and can cause confusion.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

The id in the example was misnamed and can cause confusion.
@gitpod-io
Copy link

gitpod-io bot commented Mar 6, 2021

@mergify
Copy link
Contributor

mergify bot commented Mar 6, 2021

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@skinny85 skinny85 changed the title Update id of example encrypted bucket. docs(s3): update ID of the example encrypted bucket in the ReadMe Mar 8, 2021
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @maoshouse!

@github-actions github-actions bot added the @aws-cdk/aws-s3 Related to Amazon S3 label Mar 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: eedb1dc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d9d58af into aws:master Mar 8, 2021
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
…s#13436)

The id in the example was misnamed and can cause confusion.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-s3 Related to Amazon S3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants