chore(build): record preferred NPM publishing order #13394
Conversation
Use lerna to generate a topologically sorted list of `.tgz` files. This list will be used during publishing to impose an order on the package publishing actions. Fixes #13221.
|
|
pack.sh
Outdated
| done | ||
|
|
||
| # Record the dependency order of NPM packages into a file | ||
| # (This file will be opportunistically used during publishing, it does not need to be complete) |
There was a problem hiding this comment.
Do the ones not in this file go before or after or random? Nice to include that in the comment.
There was a problem hiding this comment.
Unspecified, do not rely on any behavior there.
The details of how everything works will be documented in the PR that introduces the feature in aws-delivlib.
pack.sh
Outdated
|
|
||
| # Record the dependency order of NPM packages into a file | ||
| # (This file will be opportunistically used during publishing, it does not need to be complete) | ||
| node_modules/.bin/lerna exec \ |
There was a problem hiding this comment.
why not lerna ls --toposort? Isn't that what that's meant for?
pack.sh
Outdated
| if false; then | ||
|
|
There was a problem hiding this comment.
err.... from your local testing?
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Use lerna to generate a topologically sorted list of `.tgz` files. This list will be used during publishing to impose an order on the package publishing actions. Fixes aws#13221. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
3 participants
Use lerna to generate a topologically sorted list of
.tgzfiles.This list will be used during publishing to impose an order
on the package publishing actions.
Fixes #13221.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license