Skip to content

Conversation

@robertd
Copy link
Contributor

@robertd robertd commented Feb 25, 2021

Currently Custom Resource Provider has nodejs12.x hardcoded. This commit will change this in favor of user selected runtime (only nodejs12 at this time).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 25, 2021

@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Feb 25, 2021
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Feb 25, 2021
rix0rrr
rix0rrr previously approved these changes Feb 25, 2021
@rix0rrr rix0rrr changed the title fix(core): remove hardcoded runtime value in favor of user provided selection chore(core): remove hardcoded runtime value in favor of user provided selection Feb 25, 2021
@mergify mergify bot dismissed rix0rrr’s stale review February 25, 2021 15:56

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: cdb275f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 25, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e8984e3 into aws:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/core Related to core CDK functionality pr-linter/exempt-test The PR linter will not require test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants