fix(cloudfront): EdgeFunction us-east-1 stack created in different account #13055
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…count The us-east-1 stack for EdgeFunction was defaulting to the default deploy account. This means that using one account to deploy, and another for the stack which contains the EdgeFunction, the support stack in us-east-1 will be deployed into the deploy account, rather than stack account. This fix has the us-east-1 stack inherit the account from the parent stack. fixes #12789
|
|
github-actions
bot
added
the
@aws-cdk/aws-cloudfront
nija-at
approved these changes
Feb 15, 2021
packages/@aws-cdk/aws-cloudfront/test/experimental/edge-function.test.ts
Show resolved
Hide resolved
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
…count (aws#13055) The us-east-1 stack for EdgeFunction was defaulting to the default deploy account. This means that using one account to deploy, and another for the stack which contains the EdgeFunction, the support stack in us-east-1 will be deployed into the deploy account, rather than stack account. This fix has the us-east-1 stack inherit the account from the parent stack. fixes aws#12789 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The us-east-1 stack for EdgeFunction was defaulting to the default deploy
account. This means that using one account to deploy, and another for the stack
which contains the EdgeFunction, the support stack in us-east-1 will be deployed
into the deploy account, rather than stack account.
This fix has the us-east-1 stack inherit the account from the parent stack.
fixes #12789
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license