chore: prepare tests to expire feature flag 'kms:defaultKeyPolicies' #12922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to - 31b1b32. Unit tests in the S3 module assert resources generated by KMS. With the '@aws-cdk/aws-kms:defaultKeyPolicies' feature flag being reset as part of CDKv2, these tests need to be updated accordingly.
|
|
njlynch
reviewed
Feb 8, 2021
nija-at
changed the title
nija-at
added
@aws-cdk/aws-glue
nija-at
changed the title
nija-at
added
@aws-cdk/aws-kinesis
njlynch
approved these changes
Feb 9, 2021
Co-authored-by: Nick Lynch <[email protected]>
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
NovakGu
pushed a commit
to NovakGu/aws-cdk
that referenced
this pull request
Feb 18, 2021
…ws#12922) This is a follow up to - 31b1b32. Unit tests in the `aws-s3` and `aws-glue` modules assert resources generated by KMS. The '@aws-cdk/aws-kms:defaultKeyPolicies' feature flag will be reset in CDKv2. Update the necessary tests so that they continue to work when this happens. Two course of actions are taken here - some tests needed to be made more 'precise' in their assertions, and others had to be configured to only run in CDKv1. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to - 31b1b32.
Unit tests in the
aws-s3andaws-gluemodules assertresources generated by KMS.
The '@aws-cdk/aws-kms:defaultKeyPolicies' feature flag will be
reset in CDKv2. Update the necessary tests so that they continue
to work when this happens.
Two course of actions are taken here - some tests needed to
be made more 'precise' in their assertions, and others had to be
configured to only run in CDKv1.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license