Skip to content

feat(ecs-patterns): Add support for taskSubnets and securityGroups on QueueProcessingFagateService #12604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Feb 17, 2021
Merged

feat(ecs-patterns): Add support for taskSubnets and securityGroups on QueueProcessingFagateService #12604

merged 11 commits into from
Feb 17, 2021

Conversation

@lgvo
Copy link
Contributor

@lgvo lgvo commented Jan 19, 2021 •
edited by SoManyHs
Loading

Fixes #12603

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 19, 2021 •
edited
Loading

@lgvo
Copy link
Contributor Author

lgvo commented Jan 19, 2021

Tested the construct with and without the new options using the new (added) integ tests. Created the stacks and validated that the service was consuming the messages from the queue.

@SoManyHs SoManyHs added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Jan 20, 2021
@SoManyHs SoManyHs self-assigned this Jan 20, 2021
@SoManyHs SoManyHs linked an issue Jan 20, 2021 that may be closed by this pull request
(ecs-patterns): Add support to define specific subnets and security groups on QueueProcessingFargateService construct #12603
Closed
2 tasks
@lgvo lgvo mentioned this pull request Feb 5, 2021
Closed
2 tasks
SoManyHs
SoManyHs previously approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 Thanks so much for contributing!!

@mergify mergify bot dismissed SoManyHs’s stale review February 16, 2021 00:47

Pull request has been modified.

@SoManyHs
Copy link
Contributor

SoManyHs commented Feb 16, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Command update: success

Branch already up to date

@SoManyHs
Copy link
Contributor

SoManyHs commented Feb 16, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 16, 2021

Command update: success

Branch already up to date

@SoManyHs
Copy link
Contributor

SoManyHs commented Feb 17, 2021

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2021

Command update: success

Branch has been successfully updated

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Feb 17, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: b89f09f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 996e69d into aws:master Feb 17, 2021
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
@lgvo @NovakGu
feat(ecs-patterns): Add support for taskSubnets and securityGroups on…
d61dfdd 
… QueueProcessingFagateService (aws#12604)

Fixes aws#12603 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
@lgvo
feat(ecs-patterns): Add support for taskSubnets and securityGroups on…
5769bd3 
… QueueProcessingFagateService (#12604)

Fixes #12603 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@SoManyHs SoManyHs SoManyHs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SoManyHs SoManyHs

Labels

@aws-cdk/aws-ecs-patterns Related to ecs-patterns library

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(ecs-patterns): Add support to define specific subnets and security groups on QueueProcessingFargateService construct

3 participants

@lgvo @SoManyHs @aws-cdk-automation