Skip to content

Conversation

@nija-at
Copy link
Contributor

@nija-at nija-at commented Jan 15, 2021

We've moved off the npm client and onto yarn a long time ago. These scripts are still
using the npm client.

Instead switch them to use the yarn command. No substantial difference, just
consistency.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@nija-at nija-at requested a review from a team January 15, 2021 12:30
@nija-at nija-at self-assigned this Jan 15, 2021
@gitpod-io
Copy link

gitpod-io bot commented Jan 15, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jan 15, 2021
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I fully understand why this matters, but ok...

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4d6d99d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 17, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 93735aa into master Jan 17, 2021
@mergify mergify bot deleted the nija-at/npmrun2yarn branch January 17, 2021 09:06
mohanrajendran pushed a commit to mohanrajendran/aws-cdk that referenced this pull request Jan 24, 2021
We've moved off the npm client and onto yarn a long time ago. These scripts are still
using the npm client.

Instead switch them to use the `yarn` command. No substantial difference, just
consistency.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribution/core This is a PR that came from AWS.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants