chore(pkglint): validate that package maturity is correct
#12519
Conversation
We were missing a few cases where we did not validate that a package had the correct `maturity` set: - A package with L2s could still have a `matuirty` of 'cfn-only' - A package with only L1s could still have a non-'cfn-only' maturity Fix that in the linter, along with the violations discovered.
|
|
skinny85
changed the title
maturity is correctmaturity is correct
Co-authored-by: Jonathan Goldwasser <[email protected]>
| "node": ">= 10.13.0 <13 || >=13.7.0" | ||
| }, | ||
| "stability": "experimental", | ||
| "maturity": "cfn-only", |
There was a problem hiding this comment.
Not sure if this qualifies as an L2 - https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-acmpca/lib/certificate-authority.ts
There was a problem hiding this comment.
I think the certificate-authority.ts definitely makes it an L2.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
We were missing a few cases where we did not validate that a package had the correct `maturity` set: - A package with L2s could still have a `maturity` of 'cfn-only' - A package with only L1s could still have a non-'cfn-only' `maturity` Fix that in the linter, along with the violations discovered. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
5 participants
We were missing a few cases where we did not validate that a package had the correct
maturityset:maturityof 'cfn-only'maturityFix that in the linter, along with the violations discovered.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license