chore(scripts): compat check will compare against last published version #12509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script currently does not support publishing CDKv2. Update the script so as to read the baseline version by resolving the version from the repo's current state (from `resolve-version.js`). If the resolved version is not present in NPM, usually because the version is not *yet* published, fallback to an environment variable NPM_DISTTAG that specifies the dist tag to use.
|
|
njlynch
reviewed
Jan 15, 2021
njlynch
approved these changes
Jan 15, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mohanrajendran
pushed a commit
to mohanrajendran/aws-cdk
that referenced
this pull request
Jan 24, 2021
…ion (aws#12509) The script currently does not support publishing CDKv2. Update the script so as to read the baseline version by resolving the version from the repo's current state (from `resolve-version.js`). If the resolved version is not present in NPM, usually because the version is not *yet* published, fallback to an environment variable `NPM_DISTTAG` that specifies the dist tag to use. ref: aws/cdk-ops#1151 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script currently does not support publishing CDKv2.
Update the script so as to read the baseline version by resolving the
version from the repo's current state (from
resolve-version.js).If the resolved version is not present in NPM, usually because the
version is not yet published, fallback to an environment variable
NPM_DISTTAGthat specifies the dist tag to use.ref: aws/cdk-ops#1151
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license