fix(cdk): don't use instanceof in App #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the Stack instance test no longer use instanceof, which doesn't work properly in case of multiple installed copies of the library. This does not resolve but helps with #1245.
|
Not a fix but addresses the immediate symptoms |
eladb
reviewed
Nov 27, 2018
| @@ -438,7 +438,7 @@ export abstract class Referenceable extends StackElement { | |||
| * | |||
| * We do attribute detection since we can't reliably use 'instanceof'. | |||
| */ | |||
| function isStack(construct: Construct): construct is Stack { | |||
| export function isStack(construct: Construct): construct is Stack { | |||
There was a problem hiding this comment.
Can we make it a static method? Stack.isStack (like Array.isArray)?
There was a problem hiding this comment.
I wanted to do that, but I was worried it will conflict with stack.isStack = true.
I didn't test, though, so I could.
There was a problem hiding this comment.
Worries unfounded, it does work.
eladb
approved these changes
Nov 27, 2018
|
Wouldn'tya know it, it's our friend C# again: |
Maybe deprecate the public |
eladb
approved these changes
Nov 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the Stack instance test no longer use instanceof, which doesn't
work properly in case of multiple installed copies of the library.
This does not resolve but helps with #1245.
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
tests
manually executed (paste output to the PR description)
(currently maintained in a private repo).
Documentation
Title and description
fix(module): <title>bug fix (patch)feat(module): <title>feature/capability (minor)chore(module): <title>won't appear in changelogbuild(module): <title>won't appear in changelogBREAKING CHANGE: <describe exactly what changed and how to achieve similar behavior + link to documentation/gist/issue if more details are required>Fixes #xxxorCloses #xxxBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.