Skip to content

chore: auto approve v2 release PRs #12471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nija-at merged 3 commits into from
Jan 13, 2021
Merged

chore: auto approve v2 release PRs #12471

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd48531
chore: auto approve v2 release PRs
Jan 12, 2021
7b49d9a
switch to a single label
Jan 13, 2021
8c3d4aa
Merge branch 'master' into nija-at/autoapprove-autorelease
Jan 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/auto-approve-v2-merge-forward.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Automatically approve PRs that merge master forward to v2-main
#
# Only does approvals! mergify takes care of the actual merge.
name: Auto-approve forward merges onto v2-main
name: Auto-approve automated PRs around CDK v2
on:
pull_request:
types:
Expand All @@ -21,6 +21,6 @@ jobs:
if: >
github.event.pull_request.user.login == 'aws-cdk-automation'
&& github.event.pull_request.base.ref == 'v2-main'
&& contains(github.event.pull_request.labels.*.name, 'pr/forward-merge')
Copy link
Contributor

@eladb eladb Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just create a label pr/auto-merge and apply it in both cases?

Copy link
Contributor Author

@nija-at nija-at Jan 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duh. yes, of course.

&& contains(github.event.pull_request.labels.*.name, 'pr/auto-approve')
with:
github-token: "${{ secrets.GITHUB_TOKEN }}"