Skip to content

feat(eks): spot interruption handler can be disabled for self managed nodes #12453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mergify merged 11 commits into from
Jan 12, 2021
Merged

feat(eks): spot interruption handler can be disabled for self managed nodes #12453

mergify merged 11 commits into from
Jan 12, 2021

Conversation

@kimxogus
Copy link
Contributor

@kimxogus kimxogus commented Jan 11, 2021 •
edited by iliapolo
Loading

Added spotInterruptHandler to addAutoScalingGroupCapacity and connectAutoScalingGroupCapacity that allows disabling the installation of the spot-interrupt-handler helm chart.

Closes #12451

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 11, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Jan 11, 2021
@kimxogus kimxogus force-pushed the kimxogus/add-spot-interrupt-handler-option branch from f47b5a1 to bbf0bc7 Compare January 11, 2021 04:25
@iliapolo iliapolo changed the title feat(aws-eks): add addSpotInterruptHandler option feat(eks): add addSpotInterruptHandler option Jan 12, 2021
@iliapolo iliapolo changed the title feat(eks): add addSpotInterruptHandler option feat(eks): spot interruption handler can be disabled for self managed nodes Jan 12, 2021
iliapolo
iliapolo previously requested changes Jan 12, 2021
View reviewed changes
@iliapolo iliapolo added the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jan 12, 2021
@mergify mergify bot dismissed iliapolo’s stale review January 12, 2021 12:24

Pull request has been modified.

@kimxogus kimxogus force-pushed the kimxogus/add-spot-interrupt-handler-option branch from 56fe586 to 9c88773 Compare January 12, 2021 12:33
@kimxogus
Copy link
Contributor Author

kimxogus commented Jan 12, 2021

@iliapolo Applied changes! Can you review again?

iliapolo
iliapolo previously requested changes Jan 12, 2021
View reviewed changes
@mergify mergify bot dismissed iliapolo’s stale review January 12, 2021 13:34

Pull request has been modified.

iliapolo
iliapolo reviewed Jan 12, 2021
View reviewed changes
iliapolo
iliapolo previously approved these changes Jan 12, 2021
View reviewed changes
@iliapolo iliapolo removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Jan 12, 2021
@mergify mergify bot dismissed iliapolo’s stale review January 12, 2021 14:32

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

aws-cdk-automation commented Jan 12, 2021

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cd69dc6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 12, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 6ac1f4f into aws:master Jan 12, 2021
@kimxogus kimxogus deleted the kimxogus/add-spot-interrupt-handler-option branch January 13, 2021 00:58
@mrsiejas
Copy link
Contributor

mrsiejas commented Aug 9, 2021 •
edited
Loading

@iliapolo did you consider to pass configuration arguments to the spot_interrupt_handler instead of making it boolean? is it possible to parameterize spot_interrupt_handler with this cdk built in handler or it has to be done separately via helm chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iliapolo iliapolo iliapolo approved these changes

Assignees

@iliapolo iliapolo

Labels

@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

(aws-eks): Option not to add spot interrupt handler when adding spot asg

4 participants

@kimxogus @aws-cdk-automation @mrsiejas @iliapolo