Skip to content

chore(lambda): throw a relevant error message when asset is used across stacks #12420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 5 commits into from
Jan 11, 2021
Merged

chore(lambda): throw a relevant error message when asset is used across stacks #12420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7db44e9
feat(lambda): AssetCode instance can be used in multiple stacks
Jan 8, 2021
38169eb
Revert "feat(lambda): AssetCode instance can be used in multiple stacks"
Jan 11, 2021
98b1bc1
throw an error instead
Jan 11, 2021
6be0a4e
better message
Jan 11, 2021
b4c2de5
Merge branch 'master' into nija-at/lambda-asset
mergify[bot] Jan 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/@aws-cdk/aws-lambda/lib/code.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,9 @@ export class AssetCode extends Code {
path: this.path,
...this.options,
});
} else if (cdk.Stack.of(this.asset) !== cdk.Stack.of(scope)) {
throw new Error(`Asset is already associated with another stack '${cdk.Stack.of(this.asset).stackName}'. ` +
'Create a new Code instance for every stack.');
}

if (!this.asset.isZipArchive) {
Expand Down
20 changes: 20 additions & 0 deletions packages/@aws-cdk/aws-lambda/test/code.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,26 @@ describe('code', () => {
},
}, ResourcePart.CompleteDefinition);
});

test('fails if asset is bound with a second stack', () => {
// GIVEN
const asset = lambda.Code.fromAsset(path.join(__dirname, 'my-lambda-handler'));

const app = new cdk.App();
const stack1 = new cdk.Stack(app, 'Stack1');
new lambda.Function(stack1, 'Func', {
code: asset,
runtime: lambda.Runtime.NODEJS_10_X,
handler: 'foom',
});

const stack2 = new cdk.Stack(app, 'Stack2');
expect(() => new lambda.Function(stack2, 'Func', {
code: asset,
runtime: lambda.Runtime.NODEJS_10_X,
handler: 'foom',
})).toThrow(/already associated/);
});
});

describe('lambda.Code.fromCfnParameters', () => {
Expand Down