fix(apigatewayv2): vpclink - explicit subnet specification still causes private subnets to be included #12401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-apigatewayv2
nija-at
reviewed
Jan 7, 2021
nija-at
changed the title
Contributor
Author
|
@nija-at The title of this fix can be misleading since by default we add private subnets of the VPC if no subnets are specified |
nija-at
changed the title
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(apigatewayv2): specifying subnets to vpclink explicitly adds extra subnets
BREAKING CHANGE:
subnetsprop inVpcLinkresource now takesSubnetSelectioninstead ofISubnet[]closes #12083
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license