Skip to content

Conversation

@mbonig
Copy link
Contributor

@mbonig mbonig commented Dec 30, 2020


Recently helped someone through using this .fromString with a JsonPath. While the Overview README for the module has a good example I felt it would help by copying that example down here, so that it's immediately obvious with intellisense help.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 30, 2020

@mergify
Copy link
Contributor

mergify bot commented Dec 30, 2020

Title does not follow the guidelines of Conventional Commits. Please adjust title before merge.

@mbonig mbonig changed the title docsadding examples to the fromString docs(stepfunctions): adding examples to the fromString Dec 30, 2020
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Dec 30, 2020
@mbonig
Copy link
Contributor Author

mbonig commented Dec 31, 2020

Any suggestions on why the codebuild is failing?

@skinny85
Copy link
Contributor

@mbonig Our log publishing was failing for a while, but @NetaNir fixed it today. Change the PR in some way (update with master, push an empty commit, etc.), and you should get the comment with the publicly-available logs.

shivlaks
shivlaks previously approved these changes Dec 31, 2020
@mergify mergify bot dismissed shivlaks’s stale review December 31, 2020 02:30

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 7a0646b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 122a76d into aws:master Jan 4, 2021
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
----

Recently helped someone through using this .fromString with a JsonPath. While the Overview README for the module has a good example I felt it would help by copying that example down here, so that it's immediately obvious with intellisense help.

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@mbonig mbonig deleted the patch-3 branch January 6, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

@aws-cdk/aws-stepfunctions Related to AWS StepFunctions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants