chore(eks): updated the eks launch template support topic in the docs #12272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-eks
fixes aws#12256 Clarified the usage of custom user data with default or custom AMI by adding another example and pointing out the differences. Also changed the launch template reference in the examples to use the latest version rather than the default. If you don't know the difference it would be unexpected for an user to change the user data without having it applied to the nodes after deploy. Make the sentence about defining instance type either in launch template or node group more understandable.
dirknilius
force-pushed
the
feature/clarify-eks-launch-template-docs
branch
from
6b4cf44 to
014e956
Compare
iliapolo
changed the title
iliapolo
reviewed
Jan 15, 2021
iliapolo
previously approved these changes
Jan 15, 2021
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
previously approved these changes
Jan 15, 2021
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
approved these changes
Jan 15, 2021
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Collaborator
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Contributor
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mohanrajendran
pushed a commit
to mohanrajendran/aws-cdk
that referenced
this pull request
Jan 24, 2021
…aws#12272) Closes aws#12256 Clarified the usage of custom user data with default or custom AMI by adding another example and pointing out the differences. Changed the launch template reference in the examples to use the latest version rather than the default. If you don't know the difference it would be unexpected for the user to change the user data without having it applied to the nodes after deploy. Removed unnecessary wrapping of instance type string with typed version and calling toString. Make the sentence about defining instance type either in launch template or node group more understandable. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12256
Clarified the usage of custom user data with default or custom AMI by adding another example and pointing out the differences.
Changed the launch template reference in the examples to use the latest version rather than the default. If you don't know the difference it would be unexpected for the user to change the user data without having it applied to the nodes after deploy.
Removed unnecessary wrapping of instance type string with typed version and calling toString.
Make the sentence about defining instance type either in launch template or node group more understandable.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license