-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(synthetics): Update Cloudwatch Synthetics canaries NodeJS runtimes #11866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7c09f34
update canaries runtime
flochaz ddb3ba8
Fix semantic test
flochaz 854cc71
Merge branch 'master' into flochaz/updatedCanaryRuntime
flochaz 26070df
removed python runtime, will be part of another PR
flochaz d4e53a3
Merge branch 'master' into flochaz/updatedCanaryRuntime
flochaz 6749576
don't modify unit test
flochaz 6d2b666
update examples with latest runtime
flochaz bd18327
Merge branch 'master' into flochaz/updatedCanaryRuntime
flochaz b143f42
Merge branch 'master' into flochaz/updatedCanaryRuntime
NetaNir 1e883ae
Merge branch 'master' into flochaz/updatedCanaryRuntime
NetaNir File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been removed when the
runtimeproperty was made a required property. Can you remove it (instead of fixing it)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed it, I just mentioned that pupetter is for nodejs runtime only since python one use selenium. But If you prefer I'll keep that for python PR.