Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for liveData feature in CloudWatch Dashboards #8376

Closed
2 tasks
ivoanjo opened this issue Jun 4, 2020 · 0 comments · Fixed by #8579
Closed
2 tasks

Add support for liveData feature in CloudWatch Dashboards #8376

ivoanjo opened this issue Jun 4, 2020 · 0 comments · Fixed by #8579
Assignees
@rix0rrr
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.

Comments

@ivoanjo
Copy link
Contributor

ivoanjo commented Jun 4, 2020

CDK is missing support for liveData in (see https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html) in CloudWatch dashboards.

This was also requested in #2385 but that issue was closed without including liveData.

Use Case

I want to use this feature in my dashboards.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@ivoanjo ivoanjo added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 4, 2020
@SomayaB SomayaB added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Jun 5, 2020
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jun 8, 2020
@kaizencc kaizencc mentioned this issue Jun 16, 2020
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. and removed needs-triage This issue or PR still needs to be triaged. labels Jun 17, 2020
@mergify mergify bot closed this as completed in #8579 Jun 18, 2020
mergify bot pushed a commit that referenced this issue Jun 18, 2020
@kaizencc
feat(cloudwatch): liveData in GraphWidget (#8579)
831092e 
CDK is missing support for `liveData` property in GraphWidget. The properties are defined [here](https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/CloudWatch-Dashboard-Body-Structure.html) under "Metric Widget Object."

The optional properties `period` and `stat` are also not supported in Cloudwatch currently. I wonder if there are use cases for those as well.

This PR adds `liveData` to `GraphWidgetProps` and defaults to `false`. It fixes #8376 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): liveData in GraphWidget
3 participants
@rix0rrr @ivoanjo @SomayaB