(core): flaky Rosetta run

[phuhung273]

Describe the bug

Rosetta fail very often with: Error: @aws-cdk.aws-pipes-alpha-README-L305.ts:16:27 - error TS2307: Cannot find module '@aws-cdk/aws-pipes-sources-alpha' or its corresponding type declarations.

Confirm that is false alert, rerun usually work.

Regression Issue

• Select this option if this issue appears to be a regression.

Last Known Working CDK Library Version

No response

Expected Behavior

Rosetta run should be consistent.

Current Behavior

Rosetta run is flaky.

Reproduction Steps

None, it just fails a lot and rerun works most of the time.

Possible Solution

No response

Additional Information/Context

No response

AWS CDK Library version (aws-cdk-lib)

all

AWS CDK CLI version

all

Node.js Version

all

OS

all

Language

TypeScript

Language Version

No response

Other information

No response

[mrgrain]

Thanks @phuhung273 This looks like a race condition to me.

As part of example transpilation, Rosetta ensures that the TS example compiles successfully. In this case it looks like an example in @aws-cdk/aws-pipes-alpha depends on @aws-cdk/aws-pipes-sources-alpha. However (rightfully!!!) the package doesn't declare a dependency of @aws-cdk/aws-pipes-sources-alpha. So the required sources packages might end up being available or not. Not entirely sure how it sometimes work and sometimes not, but a retry could play a role here.

I believe declaring the dependency for rosetta here should fix it:

aws-cdk/packages/@aws-cdk/aws-pipes-alpha/package.json

Line 116 in 6c4181b

"exampleDependencies": {}

[phuhung273]

Thanks for the instruction @mrgrain, let me create a PR for that.

Edited: maybe lets have some more time investigating

[phuhung273]

Few things to notice:

• @aws-cdk/aws-pipes-alpha and @aws-cdk/aws-pipes-sources-alpha circularly depend on each other
• only pipes-*-alpha module has empty jsiiRosetta in package.json

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.