Adding VPC Gateway Endpoint to VPC created fromLookup fails

[vaneek]

Note: for support questions, please first reference our documentation, then use Stackoverflow. This repository's issues are intended for feature requests and bug reports.

• I'm submitting a ...

  • 🪲 bug report
  • 🚀 feature request
  • 📚 construct library gap
  • ☎️ security issue or vulnerability => Please see policy
  • ❓ support request => Please see note at the top of this template.

• What is the current behavior?
  If the current behavior is a 🪲bug🪲: Please provide the steps to reproduce

Adding a VPC gateway type endpoint to a VPC referenced by Vpc.fromLookup fails with AttributeError: '_IVpcProxy' object has no attribute 'add_gateway_endpoint'

Python code;

vpc = ec2.Vpc.from_lookup(self, "VPC", is_default=True)

s3_endpoint = vpc.add_gateway_endpoint('S3Endpoint', 
    service=ec2.GatewayVpcEndpointAwsService('s3'))

Similar error message using vpc. add­_s3­_endpoint().

though ,

storage_gateway_endpoint = vpc.add_interface_endpoint('StorageGatewayEndpoint', 
            service=ec2.InterfaceVpcEndpointAwsService('storagegateway'))

is successful.

• What is the expected behavior (or behavior of feature suggested)?

• What is the motivation / use case for changing the behavior or adding this feature?

• Please tell us about your environment:

  • CDK CLI Version: 1.2.0
  • Module Version: xx.xx.xx
  • OS: [all | Windows 10 | OSX Mojave | Ubuntu | etc... ]
  • Language: [ Python ]

• Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)

[vaneek]

from aws_cdk import (
    aws_iam as iam,
    aws_ec2 as ec2,
    aws_autoscaling as autoscaling,
    core
)


class FileGatewayStack(core.Stack):

    def __init__(self, scope: core.Construct, id: str, **kwargs) -> None:
        super().__init__(scope, id, **kwargs)
        vpc = ec2.Vpc.from_lookup(self, "VPC", is_default=True)
        # vpc = ec2.Vpc(self, "VPC")
        
        asg = autoscaling.AutoScalingGroup(
            self, "ASG",
            vpc=vpc,
            # vpc_subnets=vpc.select_subnets(subnet_type=ec2.SubnetType.PUBLIC, one_per_az=True),
            instance_type=ec2.InstanceType.of(
                ec2.InstanceClass.BURSTABLE3, ec2.InstanceSize.LARGE
            ),
            machine_image=ec2.GenericLinuxImage({
                'eu-west-2': 'ami-0b899ea99c9087f96',
                'eu-west-1': 'ami-02ea6e7d49330d41b',
            }),
        )
        
        storage_gateway_endpoint = vpc.add_interface_endpoint('StorageGatewayEndpoint', 
            service=ec2.InterfaceVpcEndpointAwsService('storagegateway'))
            
        s3_endpoint = vpc.add_s3_endpoint('S3Endpoint')

[jogold]

This is because gateway endpoints need route table ids and those were not available on imported VPCs when the feature was added (#2104). I can maybe have a look at this.

[ozahavi]

Still having a problem when trying to add a gateway endpoint to a VPC that was imported using "vpc.fromLookup".
Error message: 'Can't add a gateway endpoint to VPC; route table IDs are not available'.

CDK 1.84, MacOS BigSur, Node 12.18.3.

[twitu]

I'm observing the same for CDK 1.102.0, Amazon Linux 2, Node v14.17.0

Has anybody found a fix for this?

[dnz-bdeboer]

Get exactly the same error even when the vpc is not imported.

[urosn74]

For what is worth, in my case it helped when I deleted cdk.context.json.

[cyuste]

In my scenario multiple subnets are sharing the same route table and this causes the gateway endpoint creation to fail. Using cfn resource solves the issue

[JoshMcCullough]

I'm running into this issue with an imported VPC (VPC.fromLookup), when creating an S3 Gateway endpoint:

  const vpc = Vpc.fromLookup(stack, ResourceIds.VPC.for(vpcName), {
    vpcName,
  });
  const interfaceServices = {
    ecr: InterfaceVpcEndpointAwsService.ECR,
    "ecr-dkr": InterfaceVpcEndpointAwsService.ECR_DOCKER,
    "ssm-messages": InterfaceVpcEndpointAwsService.SSM_MESSAGES,
    logs: InterfaceVpcEndpointAwsService.CLOUDWATCH_LOGS,
  };
  const gatewayServices = {
    "s3-gateway": GatewayVpcEndpointAwsService.S3,
  };

  Object
    .entries(interfaceServices)
    .forEach(([ name, service ]) => vpc.addInterfaceEndpoint(ResourceIds.VpcEndpoint.for(name), {
      service,
      subnets: {
        subnets,
      },
      securityGroups: [
        stack.securityGroups.vpcEndpoints,
      ],
    }));

  Object
    .entries(gatewayServices)
    .forEach(([ name, service ]) => vpc.addGatewayEndpoint(ResourceIds.VpcEndpoint.for(name), {
      service,
      subnets: [ {
        subnets,
      } ],
    }));