Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(stepfunctions): No option for CSV Delimiter #33418

Closed
2 tasks
stephen-christie-ss opened this issue Feb 12, 2025 · 2 comments · Fixed by #33558
Closed
2 tasks

(stepfunctions): No option for CSV Delimiter #33418

stephen-christie-ss opened this issue Feb 12, 2025 · 2 comments · Fixed by #33558
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@stephen-christie-ss
Copy link

Describe the feature

The CSVDelimiter field for the Step Function ItemReader is not available in the S3CsvItemReader.

Use Case

I need to select a semicolon delimiter, to support European CSV files.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

aws-cdk-lib 2.176.0

Environment details (OS name and version, etc.)

Ubuntu 24.04
@stephen-christie-ss stephen-christie-ss added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 12, 2025
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Feb 12, 2025
@stephen-christie-ss stephen-christie-ss changed the title (module name): (short(stepfunctions): No option for CSV Delimiter issue description) (stepfunctions): No option for CSV Delimiter Feb 12, 2025
@pahud pahud self-assigned this Feb 12, 2025
@pahud
Copy link
Contributor

pahud commented Feb 12, 2025

Yes I guess here's what we need to do to fix this:

  1. The S3CsvItemReaderProps interface needs to be updated to include the csvDelimiter property
  2. The S3CsvItemReader class needs to be modified to include this property in its render() method

We welcome PRs.

@pahud pahud added p2 effort/medium Medium work item – several days of effort labels Feb 12, 2025
@pahud pahud removed their assignment Feb 12, 2025
@pahud pahud removed the needs-triage This issue or PR still needs to be triaged. label Feb 12, 2025
@mazyu36 mazyu36 mentioned this issue Feb 22, 2025
Merged
1 task
@mergify mergify bot closed this as completed in #33558 Feb 25, 2025
mergify bot pushed a commit that referenced this issue Feb 25, 2025
@mazyu36
feat(stepfunctions): add support for custom CSV delimiters in S3CsvIt…
43ae4fc 
…emReader (#33558)

### Issue # (if applicable)

Closes #33418.

### Reason for this change
CSVDelimiter in ItemReader is not supported in L2 Construct.

Ref: https://docs.aws.amazon.com/step-functions/latest/dg/input-output-itemreader.html#itemreader-field-contents


### Description of changes

Add `csvDelimiter` property.



### Describe any new or updated permissions being added
Nothing.



### Description of how you validated changes
Add a unit test and an integ test.


### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(stepfunctions): add support for custom CSV delimiters in S3CsvItemReader mazyu36/aws-cdk
2 participants
@pahud @stephen-christie-ss