Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

elasticloadbalancingv2: client keep alive #29503

Closed
1 of 2 tasks
badmintoncryer opened this issue Mar 15, 2024 · 1 comment · Fixed by #29504 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed
1 of 2 tasks

elasticloadbalancingv2: client keep alive #29503

badmintoncryer opened this issue Mar 15, 2024 · 1 comment · Fixed by #29504 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@badmintoncryer
Copy link
Contributor

Describe the feature

We can configure client keepalive duration for ALB by AWS CDK.

Use Case

ALB now supports configuring HTTP client keepalive duration but CDK cannot configure that.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.132.0

Environment details (OS name and version, etc.)

irrelevant
@badmintoncryer badmintoncryer added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 15, 2024
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Mar 15, 2024
@badmintoncryer badmintoncryer mentioned this issue Mar 15, 2024
Merged
1 task
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Mar 15, 2024
@github-actions github-actions bot mentioned this issue Mar 18, 2024
Closed
@mergify mergify bot closed this as completed in #29504 Mar 22, 2024
mergify bot pushed a commit that referenced this issue Mar 22, 2024
@badmintoncryer
feat(elasticloadbalancingv2): client keepalive for ALB (#29504)
9b79f94 
### Issue # (if applicable)

Closes #29503.

### Reason for this change

[ALB supports configuring client keepalive duration](https://aws.amazon.com/jp/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/) but AWS CDK cannot do that.

### Description of changes

Add `clientKeepAlive` properties to `ApplicationLoadBalancerProps`.

```ts
      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });
```

### Description of how you validated changes

I've added both integ and unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

jun1-t pushed a commit to jun1-t/aws-cdk that referenced this issue Mar 23, 2024
@badmintoncryer @jun1-t
feat(elasticloadbalancingv2): client keepalive for ALB (aws#29504)
6be44d0 
### Issue # (if applicable)

Closes aws#29503.

### Reason for this change

[ALB supports configuring client keepalive duration](https://aws.amazon.com/jp/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/) but AWS CDK cannot do that.

### Description of changes

Add `clientKeepAlive` properties to `ApplicationLoadBalancerProps`.

```ts
      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });
```

### Description of how you validated changes

I've added both integ and unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahammond pushed a commit to ahammond/aws-cdk that referenced this issue Mar 26, 2024
@badmintoncryer @ahammond
feat(elasticloadbalancingv2): client keepalive for ALB (aws#29504)
db411a4 
### Issue # (if applicable)

Closes aws#29503.

### Reason for this change

[ALB supports configuring client keepalive duration](https://aws.amazon.com/jp/about-aws/whats-new/2024/03/application-load-balancer-http-keepalive-duration/) but AWS CDK cannot do that.

### Description of changes

Add `clientKeepAlive` properties to `ApplicationLoadBalancerProps`.

```ts
      new elbv2.ApplicationLoadBalancer(stack, 'LB', {
        vpc,
        clientKeepAlive: Duration.seconds(250),
      });
```

### Description of how you validated changes

I've added both integ and unit tests

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Apr 1, 2024
Closed
This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this issue May 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
2 participants
@pahud @badmintoncryer