(lambda): LoggingConfig is not available in GovCloud and maybe other partitions #28919
Comments
polothy
added
bug
|
The same applies for cn-north-1 and most likely the complete aws-cn partition. I think it is not ok that you deprecate something, but then the alternative is not even available. I am facing the same issues as described above. To make it even worse the rollback fails, which is not that much fun :( |
|
related to #26947 (comment) |
pahud
added
p1
effort/medium
Thanks for letting us know and I'm sorry we missed this. Going to undeprecate. |
### Issue Closes #28919 ### Reason for this change In #28737 and #28783 we have deprecated various `logRetention` properties in favor of the new Logging Configuration feature for Lambda Functions. This new feature provides full control over the Lambda Function log group via the `logGroup` property. However Logging Configuration is not available yet for all regions. Particularly GovCloud and CN regions (at the time this issue was created). For customers in of these regions there is currently no clear migration path. We therefore revert the deprecation of previously deprecated properties. ### Description of changes Revert the deprecation of previously deprecated `logRetention` properties. Update documentation to be more explicit about the various options customers have. ### Description of how you validated changes Documentation & annotation change only. This is a partial revert of the PRs linked about, with minor documentation updates. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
### Issue Closes #28919 ### Reason for this change In #28737 and #28783 we have deprecated various `logRetention` properties in favor of the new Logging Configuration feature for Lambda Functions. This new feature provides full control over the Lambda Function log group via the `logGroup` property. However Logging Configuration is not available yet for all regions. Particularly GovCloud and CN regions (at the time this issue was created). For customers in of these regions there is currently no clear migration path. We therefore revert the deprecation of previously deprecated properties. ### Description of changes Revert the deprecation of previously deprecated `logRetention` properties. Update documentation to be more explicit about the various options customers have. ### Description of how you validated changes Documentation & annotation change only. This is a partial revert of the PRs linked about, with minor documentation updates. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
AWS CDK recently deprecated logging retention options on Lambda Function construct. When I tried to fix the deprecations, it worked fine until GovCloud deployment. CloudFormation reported this error:
Original discussion started in #26947
Expected Behavior
Not entirely sure, I had to write a condition in my code to use the deprecated options for GovCloud and use the new LogGroup option elsewhere.
Current Behavior
CloudFormation reported this error:
Reproduction Steps
Use LogGroup on the Lambda Function construct and deploy that into GovCloud.
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.118.0
Framework Version
No response
Node.js Version
18
OS
macOS Sonoma
Language
Python
Language Version
3.11
Other information
No response
The text was updated successfully, but these errors were encountered: