Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(integ-runner): (integ runner doesn't work anymore when specifying test files) #28890

Closed
GavinZZ opened this issue Jan 26, 2024 · 2 comments · Fixed by #28891
Closed

(integ-runner): (integ runner doesn't work anymore when specifying test files) #28890

GavinZZ opened this issue Jan 26, 2024 · 2 comments · Fixed by #28891
Labels
@aws-cdk/integ-runner bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@GavinZZ
Copy link
Contributor

GavinZZ commented Jan 26, 2024

Describe the bug

After this PR change, #28770, integ-runner doesn't work anymore when specifying test files, i.e. yarn integ test/aws-apigatewayv2-integrations/test/websocket/integ.aws.t --update-on-failed.

Expected Behavior

Should work and run the integration test.

Current Behavior

Invalid values:
  Argument: language, Given: "test/aws-apigatewayv2-integrations/test/websocket/integ.aws.js", Choices: "javascript", "typescript", "python", "go"

Reproduction Steps

Pull latest main

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

N/A

Framework Version

No response

Node.js Version

N/A

OS

N/A

Language

TypeScript

Language Version

No response

Other information

No response
@GavinZZ GavinZZ added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jan 26, 2024
@GavinZZ GavinZZ mentioned this issue Jan 26, 2024
Merged
@pahud
Copy link
Contributor

pahud commented Jan 29, 2024

Thank you for the report and PR.

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2024
@mergify mergify bot closed this as completed in #28891 Jan 29, 2024
mergify bot pushed a commit that referenced this issue Jan 29, 2024
@GavinZZ
chore(integ-runner): revert integ runner change that limits to run ja…
7b03a19 
…vascript tests (#28891)

After this PR change, #28770, integ-runner doesn't work anymore when specifying test files, i.e. yarn integ test/aws-apigatewayv2-integrations/test/websocket/integ.aws.t --update-on-failed.

Closes #28890

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Vandita2020 pushed a commit to Vandita2020/aws-cdk that referenced this issue Jan 30, 2024
@GavinZZ @Vandita2020
chore(integ-runner): revert integ runner change that limits to run ja…
49cab5e 
…vascript tests (aws#28891)

After this PR change, aws#28770, integ-runner doesn't work anymore when specifying test files, i.e. yarn integ test/aws-apigatewayv2-integrations/test/websocket/integ.aws.t --update-on-failed.

Closes aws#28890

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Feb 1, 2024
Closed
SankyRed pushed a commit that referenced this issue Feb 8, 2024
@GavinZZ @SankyRed
chore(integ-runner): revert integ runner change that limits to run ja…
368f031 
…vascript tests (#28891)

After this PR change, #28770, integ-runner doesn't work anymore when specifying test files, i.e. yarn integ test/aws-apigatewayv2-integrations/test/websocket/integ.aws.t --update-on-failed.

Closes #28890

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/integ-runner bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(integ-runner): revert integ runner change that limits to run javascript tests aws/aws-cdk
2 participants
@pahud @GavinZZ