(eks): Helm custom handler uninstall does not respect --wait #28831
Labels
@aws-cdk/aws-eks
Related to Amazon Elastic Kubernetes Service
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
ellistarn
added
bug
github-actions
bot
added
the
@aws-cdk/aws-eks
|
Just read your PR. Figured out we missed to pass |
pahud
added
p2
effort/small
mergify bot
pushed a commit
that referenced
this issue
Jan 25, 2024
…`Wait` (#28830) I have a stack that installs and uninstalls helm charts, where the underlying resources use [Kubernetes Finalizers](https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/). CDK's helm construct currently ignores `--wait`, which means that any object finalization in those helm charts is not respected in my dependency ordering. ## Compatibility I could see some debate around whether or not this is a breaking change. I'm currently viewing it as a bug fix. I'm a bit cautious about how valuable it would be to gate this behavior compared to the additional complexity. ## Testing Tested on a local fork and it worked like a charm Closes #28831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Vandita2020
pushed a commit
to Vandita2020/aws-cdk
that referenced
this issue
Jan 30, 2024
…`Wait` (aws#28830) I have a stack that installs and uninstalls helm charts, where the underlying resources use [Kubernetes Finalizers](https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/). CDK's helm construct currently ignores `--wait`, which means that any object finalization in those helm charts is not respected in my dependency ordering. ## Compatibility I could see some debate around whether or not this is a breaking change. I'm currently viewing it as a bug fix. I'm a bit cautious about how valuable it would be to gate this behavior compared to the additional complexity. ## Testing Tested on a local fork and it worked like a charm Closes aws#28831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
SankyRed
pushed a commit
that referenced
this issue
Feb 8, 2024
…`Wait` (#28830) I have a stack that installs and uninstalls helm charts, where the underlying resources use [Kubernetes Finalizers](https://kubernetes.io/docs/concepts/overview/working-with-objects/finalizers/). CDK's helm construct currently ignores `--wait`, which means that any object finalization in those helm charts is not respected in my dependency ordering. ## Compatibility I could see some debate around whether or not this is a breaking change. I'm currently viewing it as a bug fix. I'm a bit cautious about how valuable it would be to gate this behavior compared to the additional complexity. ## Testing Tested on a local fork and it worked like a charm Closes #28831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When I use
--waitin the HelmChart construct, helm does not correctly wait during object deletion.Expected Behavior
Helm should pass
--waiton uninstall.Current Behavior
Dependency ordering is not respected.
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.117.0
Framework Version
No response
Node.js Version
14
OS
osx
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: