stepfunctions: Retry block in CustomState is always empty.

[troter]

Describe the bug

After this(#28422) changes, Retry block in CustomState is always empty.

because Retry is always overwritten here.

https://github.com/graydenshand/aws-cdk/blob/3e7c777f28d3375acdb6bf1446c2cd159eadce6d/packages/aws-cdk-lib/aws-stepfunctions/lib/states/custom-state.ts#L56-L65

Expected Behavior

• The Retry block passed to the constructor will be used as is.
• or add addRetry method.

Current Behavior

Retry is always overwrite by empty array.

Reproduction Steps

Pass stateJson that has Retry lock to CustomState.

const stateJson = {
    Type: "Task",
    Resource: "arn:aws:states:::ecs:runTask.sync",
    ResultPath: "$.results.ECSRunTask",
    TimeoutSeconds: defaultTimeoutHours * 60 * 60,
    Retry: [
        {
            ErrorEquals: ["ECS.AmazonECSException", "ECS.ServerException"],
            IntervalSeconds: 60,
            MaxAttempts: 3,
        },
    ],
    Parameters: {
        LaunchType: "FARGATE",
        Group: ecsServiceName,
        Cluster: clusterArn,
        TaskDefinition: taskDefinitionArn,
    },
};

const RunTaskState = new sfn.CustomState(this, "ECS RunTask.", {
    stateJson: stateJson,
});

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.116.0

Framework Version

No response

Node.js Version

18.15.0

OS

macOS Sonoma 14.2.1

Language

TypeScript

Language Version

No response

Other information

No response

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[jacklin213]

Hey @pahud,

Can the issue be re-opened. #28598 only satisfies bullet 2 in the expected behavior section in the original issue post.

I don't believe the actual regression (bullet 1) has been addressed.

Users upgrading from v2.115.0 and before, that had Retry in their stateJson passed as CustomStateProps will find that even after they upgrade to v2.119.0, the state machine definition will be missing the Retry entry.
(Tested on latest v2.121.1 version)

EDIT: Creating separate issue as suggested by the bot