Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add suport for RedriveAllowPolicy in the Queue construct #19766

Closed
1 of 2 tasks
VarshaVid opened this issue Apr 5, 2022 · 2 comments · Fixed by #28745
Closed
1 of 2 tasks

Add suport for RedriveAllowPolicy in the Queue construct #19766

VarshaVid opened this issue Apr 5, 2022 · 2 comments · Fixed by #28745
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@VarshaVid
Copy link
Contributor

Describe the feature

The CfnQueue construct the "source queue" policy for a DLQ redrive to be specified using the redriveAllowPolicy parameter but the Queue construct does not support this. Requesting to please add this support.

Use Case

SQS recently launched a feature to allow redriving DLQs via the AWS console which will help to make it super easy to redrive DLQs but it also creates a possibility for error when selecting the destination queue and a human can accidentally choose the wrong queue to redrive to. To mitigate this, SQS allows for a DLQ to be configured with a "source queue" that the messages will always be re-drived to so that selection does not need to be made for every redrive. We want to use that for our CDK-managed queues to avoid mistakes during redrives.

Proposed Solution

I propose making following changes:

  1. Add a new parameter called redriveAllowPolicy to the QueueProps construct, with type IRedriveAllowPolicy
  2. Define IRedriveAllowPolicy with 1 method to generate the corresponding CFN parameters
  3. Define 3 implementations of IRedriveAllowPolicy to "AllowAll", "DenyAll" and "ByQueue" policy as mentioned in the CfnQueue
  4. Populate the redriveAllowPolicy when creating the CfnQueue during the constructor for Queue

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

1.141

Environment details (OS name and version, etc.)

AmazonLinux2, Windows 10
@VarshaVid VarshaVid added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 5, 2022
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Apr 5, 2022
@otaviomacedo otaviomacedo added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jun 27, 2022
@otaviomacedo otaviomacedo removed their assignment Jun 27, 2022
@jdelStrother
Copy link

Am I right in thinking this would fix the "Change permissions and CloudTrail update for SQS Dead-letter queue (DLQ) redrive " prompt emails that AWS have started sending out?

@badmintoncryer badmintoncryer mentioned this issue Jan 17, 2024
Merged
@mergify mergify bot closed this as completed in #28745 Jan 29, 2024
mergify bot pushed a commit that referenced this issue Jan 29, 2024
@badmintoncryer
feat(sqs): support for permission settings for dead letter source que…
9e21803 
…ues (#28745)

This PR allows for the configuration of constraints on source queues that can designate this queue as their dead letter queue.

```ts
declare const sourceQueue: sqs.IQueue;

// Only the sourceQueue can specify this queue as the dead-letter queue.
const queue1 = new sqs.Queue(this, 'Queue1', {
  redriveAllowPolicy: {
    sourceQueues: [sourceQueue],
  }
});

// No source queues can specify this queue as the dead-letter queue.
const queue2 = new sqs.Queue(this, 'Queue2', {
  redriveAllowPolicy: {
    redrivePermission: sqs.RedrivePermission.DENY_ALL,
  }
});
```

Closes #19766.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Vandita2020 pushed a commit to Vandita2020/aws-cdk that referenced this issue Jan 30, 2024
@badmintoncryer @Vandita2020
feat(sqs): support for permission settings for dead letter source que…
ff99f3e 
…ues (aws#28745)

This PR allows for the configuration of constraints on source queues that can designate this queue as their dead letter queue.

```ts
declare const sourceQueue: sqs.IQueue;

// Only the sourceQueue can specify this queue as the dead-letter queue.
const queue1 = new sqs.Queue(this, 'Queue1', {
  redriveAllowPolicy: {
    sourceQueues: [sourceQueue],
  }
});

// No source queues can specify this queue as the dead-letter queue.
const queue2 = new sqs.Queue(this, 'Queue2', {
  redriveAllowPolicy: {
    redrivePermission: sqs.RedrivePermission.DENY_ALL,
  }
});
```

Closes aws#19766.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
SankyRed pushed a commit that referenced this issue Feb 8, 2024
@badmintoncryer @SankyRed
feat(sqs): support for permission settings for dead letter source que…
8285312 
…ues (#28745)

This PR allows for the configuration of constraints on source queues that can designate this queue as their dead letter queue.

```ts
declare const sourceQueue: sqs.IQueue;

// Only the sourceQueue can specify this queue as the dead-letter queue.
const queue1 = new sqs.Queue(this, 'Queue1', {
  redriveAllowPolicy: {
    sourceQueues: [sourceQueue],
  }
});

// No source queues can specify this queue as the dead-letter queue.
const queue2 = new sqs.Queue(this, 'Queue2', {
  redriveAllowPolicy: {
    redrivePermission: sqs.RedrivePermission.DENY_ALL,
  }
});
```

Closes #19766.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(sqs): support for permission settings for dead letter source queues badmintoncryer/aws-cdk
3 participants
@jdelStrother @otaviomacedo @VarshaVid