Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to lookup up a web socket api gateway statically #18755

Closed
2 tasks
dtabuenc opened this issue Jan 31, 2022 · 3 comments · Fixed by #18958
Closed
2 tasks

Ability to lookup up a web socket api gateway statically #18755

dtabuenc opened this issue Jan 31, 2022 · 3 comments · Fixed by #18958
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@dtabuenc
Copy link

Description

Web Socket Api gateway is missing any static lookup from* type methods similar to HttpApi such as HttpApi.fromHttpApiAttributes

This makes it very difficult to reference the web socket gateway from another stack.

Use Case

With Http API we have some setups where we define a single api gateway and then add routes and authorizers from other stacks in other repositories, allowing different microservice repositories to manage their own routes on a shared gateway/domain. We want to do something ismilar with WebSocketApi.

Proposed Solution

I imagine something similar to what is currently don in HttpApi.

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@dtabuenc dtabuenc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 31, 2022
@github-actions github-actions bot added the @aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 label Jan 31, 2022
@otaviomacedo otaviomacedo added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 4, 2022
@otaviomacedo otaviomacedo removed their assignment Feb 4, 2022
@otaviomacedo
Copy link
Contributor

I am unassigning and marking this issue as p2, which means that we are unable to work on this immediately.

We use +1s to help prioritize our work, and are happy to revaluate this issue based on community feedback. You can reach out to the cdk.dev community on Slack to solicit support for reprioritization.

@vincent-turato
Copy link
Contributor

I would like to work on a PR for this

@mergify mergify bot closed this as completed in #18958 Feb 23, 2022
mergify bot pushed a commit that referenced this issue Feb 23, 2022
)

Closes: #18755

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-apigatewayv2 Related to Amazon API Gateway v2 effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants