Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to specify GitCloneDepth in codebuild.Project #1789

Closed
piotrkubisa opened this issue Feb 19, 2019 · 1 comment · Fixed by #1798
Closed

Allow to specify GitCloneDepth in codebuild.Project #1789

piotrkubisa opened this issue Feb 19, 2019 · 1 comment · Fixed by #1798
Assignees
@skinny85
Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild feature-request A feature should be added or improved.

Comments

@piotrkubisa
Copy link

While defining the source in codebuild.Project resource I noticed GitCloneDepth property is missing. Hopefully, it is available in the codebuild.CfnProject.
@rix0rrr rix0rrr added feature-request A feature should be added or improved. @aws-cdk/aws-codebuild Related to AWS CodeBuild labels Feb 19, 2019
@skinny85 skinny85 self-assigned this Feb 19, 2019
@skinny85
Copy link
Contributor

Yep, this is a gap. Thanks for reporting @piotrkubisa .

skinny85 added a commit to skinny85/aws-cdk that referenced this issue Feb 19, 2019
@skinny85
feat(codebuild): add support for setting the gitCloneDepth property o…
41dbc86 
…n Project sources.

Also fixed the weird casing of the 'GitHubEnterPrise' SourceType enum value while I was in the area.

Fixes aws#1789
@skinny85 skinny85 mentioned this issue Feb 19, 2019
Merged
4 tasks
skinny85 added a commit that referenced this issue Feb 20, 2019
@skinny85
feat(codebuild): add support for setting the gitCloneDepth property o…
5408a53 
…n Project sources. (#1798)

Also fixed the weird casing of the 'GitHubEnterPrise' SourceType enum value while I was in the area.

Fixes #1789
eladb pushed a commit that referenced this issue Feb 26, 2019
@skinny85
feat(codebuild): add support for setting the gitCloneDepth property o…
0d4a4fb 
…n Project sources. (#1798)

Also fixed the weird casing of the 'GitHubEnterPrise' SourceType enum value while I was in the area.

Fixes #1789
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skinny85 skinny85

Labels
@aws-cdk/aws-codebuild Related to AWS CodeBuild feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
3 participants
@skinny85 @rix0rrr @piotrkubisa