Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws_docdb): support audit logging #17478

Closed
1 of 2 tasks
ahammond opened this issue Nov 11, 2021 · 4 comments · Fixed by #17570
Closed
1 of 2 tasks

(aws_docdb): support audit logging #17478

ahammond opened this issue Nov 11, 2021 · 4 comments · Fixed by #17570
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2

Comments

@ahammond
Copy link
Contributor

Description

In order to use data stores while remaining HIPAA compliant, we need to log an audit trail. DocDB has support for this https://docs.aws.amazon.com/documentdb/latest/developerguide/event-auditing.html#event-auditing-enabling-auditing but it doesn't look like there's any way to enable this via CDK. We had a similar problem with RDS and solved it using a CustomResource lambda. Is there something like this for DocDB?

Use Case

HIPAA compliance

Proposed Solution

new aws_docdb.DatabaseCluster(this, 'Name', { audit: true, ... });

When this is enabled, it would automatically create a customer Parameter Group to match the DB with audit_logs: 'enabled' and then it would trigger a custom resource that would run the equivalent of

aws docdb modify-db-cluster \
   --db-cluster-identifier sample-cluster \
   --cloudwatch-logs-export-configuration '{"EnableLogTypes":["audit"]}'

Other information

No response

Acknowledge

  • I may be able to implement this feature request
  • This feature might incur a breaking change
@ahammond ahammond added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 11, 2021
@github-actions github-actions bot added the @aws-cdk/aws-docdb Related to Amazon DocumentDB label Nov 11, 2021
@skinny85
Copy link
Contributor

Thanks for opening the issue @ahammond! As always, we encourage community contributions, so if you'd like to open us a Pull Request adding this feature, that would be fantastic! Our "Contributing" guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

Thanks,
Adam

@skinny85 skinny85 added effort/medium Medium work item – several days of effort p2 feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. and removed needs-triage This issue or PR still needs to be triaged. labels Nov 12, 2021
@skinny85 skinny85 removed their assignment Nov 12, 2021
@markussiebert
Copy link
Contributor

So maybe you can review my pr or give me some tipps?

@skinny85

@skinny85
Copy link
Contributor

So maybe you can review my pr or give me some tipps?

@skinny85

Will do 🙂.

@skinny85 skinny85 added the in-progress This issue is being actively worked on. label Nov 18, 2021
@mergify mergify bot closed this as completed in #17570 Nov 24, 2021
mergify bot pushed a commit that referenced this issue Nov 24, 2021
closes #17478 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

beezly pushed a commit to beezly/aws-cdk that referenced this issue Nov 29, 2021
closes aws#17478 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
closes aws#17478 

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-docdb Related to Amazon DocumentDB effort/medium Medium work item – several days of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p2
Projects
None yet
3 participants