-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-events-targets): Add scheduling a Redshift query to "Event Targets for Amazon EventBridge" #15712
(aws-events-targets): Add scheduling a Redshift query to "Event Targets for Amazon EventBridge" #15712
Comments
Thanks for the feature request and sample code, @dirkgomez . We welcome community contributions! If you are able, we encourage you to contribute. If you decide to contribute, please start an engineering discussion in this issue to ensure there is a commonly understood design before submitting code. This will minimize the number of review cycles and get your code merged faster. |
@njlynch I will try to figure out how a simple event target works, the CodeBuildProject looks like a good start. |
@njlynch I hit the first roadblock (which may have been the reason to not implement this in the first place). I added aws-redshift to the dependencies and the peerDependencies in package.json and I get this error: In package package.json
Can you please advise me if it makes sense to continue and if so, how? Thanks! |
For now, it probably makes the most sense to replace |
This issue has not received any attention in 1 year. If you want to keep this issue open, please leave a comment below and auto-close will be canceled. |
Just created a PR for this |
Why is this closed? There's an open PR 🤔 |
closed as duplicate of issue #31017 |
Comments on closed issues and PRs are hard for our team to see. |
### Issue # (if applicable) Closes #15712. Closes #31017. ### Reason for this change `RedshiftDataParameters` allow for a redshift query to be scheduled. This feature adds that in ### Description of changes Added in the event target and the parameter into `aws-events` ### Description of how you validated changes Added unit tests + integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
### Issue # (if applicable) Closes aws#15712. Closes aws#31017. ### Reason for this change `RedshiftDataParameters` allow for a redshift query to be scheduled. This feature adds that in ### Description of changes Added in the event target and the parameter into `aws-events` ### Description of how you validated changes Added unit tests + integration test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The event targets module has implemented a couple of event targets but is missing some, one of which is scheduling a Redshift query.
Use Case
Schedule RedShift queries.
Proposed Solution
Cloudformation already allows for this, here's my current implementation which isn't yet very CDKish:
Other
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: