aws-cdk: cdk deploy --no-execute no longer creates a unique change set instead always using the change set name of cdk-deploy-change-set with no option to override

[peteguyatt]

Change in behaviour when using cdk deploy --no-execute. It looks like in commit 00cdd2a that cdk no longer generates a unique change set instead it always creates the change set with the name of cdk-deploy-change-set. While I can see why this is helpful with certain deployment pipelines, it's broken ours as our workflow allows developers to prepare multiple change sets across a single stack.

In the referenced commit there is mention of providing override mechanisms (in this case --change-set-name) which seems to have not made it into the commit. I'm not sure if this was by design or not, however in our case it would be highly useful.

I'm filing this as a bug since it's a breaking change in functionality from our perspective, however I can also see how this could be a feature request so please accept my apologies if I have misfiled this issue.

Reproduction Steps

with any stack use cdk deploy --no-execute

What did you expect to happen?

The previous behaviour was to generate a stack name with CDK- no it just always generates the stack name of cdk-deploy-change-set

What actually happened?

Environment

• CDK CLI Version : 1.90.0 (build 7edba31)
• Framework Version: 1.78.0
• Node.js Version: v14.15.4
• Alpine Linux 3.13.0
• TypeScript (3.8.3)

Other

---

I'm happy to create a PR to address this, please let me know if this would be helpful or not.

This is 🐛 Bug Report

[rix0rrr]

I'm happy to create a PR to address this, please let me know if this would be helpful or not.

That would be greatly appreciated, thanks!

It's my understanding that only one change set can ever be executed anyway (out of N proposed), so I'm very curious about your workflow. In what way do you use multiple change sets in parallel? ( I could have sworn this would be an unused feature... 😓)

[peteguyatt]

If a feature exists there is going to be some pesky dev that will use it in some unintentional way! 😉

Typically there should only ever be one or two change sets created but we allow for developers to prepare a change set using our build pipeline so that we are not doing deploys from our personal machines. This does two things, a CDK diff and a CDK deploy --no-execute. The developers then can review their change sets and choose to deploy (execute that change set) or to carry on developing/create a change set from a different revision of the project.

[peteguyatt]

@rix0rrr Looks like a work colleague of mine has already fixed this with #13024
I'll close this issue now since it's been addressed.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.