Address feedback

aws · May 21, 2019 · f8eeb3e · f8eeb3e
1 parent d5baf5d
commit f8eeb3e
Show file tree

Hide file tree

Showing 6 changed files with 7 additions and 7 deletions.
diff --git a/design/aws-ecs-autoscaling-queue-worker.md b/design/aws-ecs-autoscaling-queue-worker.md
@@ -44,11 +44,11 @@ export interface QueueWorkerServiceBaseProps {
   readonly image: ContainerImage;
 
   /**
-   * The CMD value to pass to the container. A string with commands delimited by commas.
+   * The CMD value to pass to the container as a string array.
    *
    * @default none
    */
-  readonly command?: string;
+  readonly command?: string[];
 
   /**
    * Number of desired copies of running tasks

diff --git a/packages/@aws-cdk/aws-ecs/lib/ecs-queue-worker-service.ts b/packages/@aws-cdk/aws-ecs/lib/ecs-queue-worker-service.ts
@@ -51,7 +51,7 @@ export class Ec2QueueWorkerService extends QueueWorkerServiceBase {
       memoryLimitMiB: props.memoryLimitMiB,
       memoryReservationMiB: props.memoryReservationMiB,
       cpu: props.cpu,
-      command: props.command !== undefined ? cdk.Fn.split(",", props.command) : undefined,
+      command: props.command,
       environment: this.environment,
       logging: this.logDriver
     });

diff --git a/packages/@aws-cdk/aws-ecs/lib/fargate-queue-worker-service.ts b/packages/@aws-cdk/aws-ecs/lib/fargate-queue-worker-service.ts
@@ -59,7 +59,7 @@ export class FargateQueueWorkerService extends QueueWorkerServiceBase {
     });
     taskDefinition.addContainer('QueueWorkerContainer', {
       image: props.image,
-      command: props.command !== undefined ? cdk.Fn.split(",", props.command) : undefined,
+      command: props.command,
       environment: this.environment,
       logging: this.logDriver
     });

diff --git a/packages/@aws-cdk/aws-ecs/lib/queue-worker-service-base.ts b/packages/@aws-cdk/aws-ecs/lib/queue-worker-service-base.ts
@@ -27,7 +27,7 @@ export interface QueueWorkerServiceBaseProps {
    *
    * @default none
    */
-  readonly command?: string;
+  readonly command?: string[];
 
   /**
    * Number of desired copies of running tasks

diff --git a/packages/@aws-cdk/aws-ecs/test/test.ecs-worker-service.ts b/packages/@aws-cdk/aws-ecs/test/test.ecs-worker-service.ts
@@ -76,7 +76,7 @@ export = {
       cluster,
       memoryLimitMiB: 1024,
       image: ecs.ContainerImage.fromRegistry('test'),
-      command: "-c, 4, amazon.com",
+      command: ["-c", "4", "amazon.com"],
       enableLogging: false,
       desiredTaskCount: 2,
       environment: {

diff --git a/packages/@aws-cdk/aws-ecs/test/test.fargate-worker-service.ts b/packages/@aws-cdk/aws-ecs/test/test.fargate-worker-service.ts
@@ -75,7 +75,7 @@ export = {
       cluster,
       memoryMiB: '512',
       image: ecs.ContainerImage.fromRegistry('test'),
-      command: "-c, 4, amazon.com",
+      command: ["-c", "4", "amazon.com"],
       enableLogging: false,
       desiredTaskCount: 2,
       environment: {