unit test overriding behavior

aws · Jan 24, 2025 · c5d4908 · c5d4908
1 parent 626eb68
commit c5d4908
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 3 deletions.
diff --git a/packages/aws-cdk/test/cli/cli-arguments.test.ts b/packages/aws-cdk/test/cli/cli-arguments.test.ts
@@ -14,11 +14,11 @@ describe('yargs', () => {
         assetMetadata: undefined,
         build: undefined,
         caBundlePath: undefined,
-        context: [],
+        context: undefined,
         ignoreErrors: false,
         noColor: false,
         pathMetadata: undefined,
-        plugin: [],
+        plugin: undefined,
         profile: undefined,
         proxy: undefined,
         roleArn: undefined,
@@ -60,7 +60,7 @@ describe('yargs', () => {
         progress: undefined,
         requireApproval: undefined,
         rollback: false,
-        tags: [],
+        tags: undefined,
         toolkitStackName: undefined,
         watch: undefined,
       },

diff --git a/packages/aws-cdk/test/cli/user-config.test.ts b/packages/aws-cdk/test/cli/user-config.test.ts
@@ -3,6 +3,7 @@ import * as os from 'os';
 import * as fs_path from 'path';
 import * as fs from 'fs-extra';
 import { Configuration, PROJECT_CONFIG, PROJECT_CONTEXT } from '../../lib/cli/user-configuration';
+import { parseCommandLineArguments } from '../../lib/cli/parse-command-line-arguments';
 
 // mock fs deeply
 jest.mock('fs-extra');
@@ -112,3 +113,33 @@ test('Can specify the `quiet` key in the user config', async () => {
 
   expect(config.settings.get(['quiet'])).toBe(true);
 });
+
+test('array settings are not overridden by yarg defaults', async () => {
+  // GIVEN
+  const GIVEN_CONFIG: Map<string, any> = new Map([
+    [PROJECT_CONFIG, {
+      plugin: ['dummy'],
+    }],
+  ]);
+  const argsWithPlugin = await parseCommandLineArguments(['ls', '--plugin', '[]']);
+  const argsWithoutPlugin = await parseCommandLineArguments(['ls']);
+
+  // WHEN
+  mockedFs.pathExists.mockImplementation(path => {
+    return GIVEN_CONFIG.has(path);
+  });
+  mockedFs.readJSON.mockImplementation(path => {
+    return GIVEN_CONFIG.get(path);
+  });
+
+  const configWithPlugin = await new Configuration({
+    commandLineArguments: argsWithPlugin,
+  }).load();
+  const configWithoutPlugin = await new Configuration({
+    commandLineArguments: argsWithoutPlugin,
+  }).load();
+
+  // THEN
+  expect(configWithPlugin.settings.get(['plugin'])).toEqual(['[]']);
+  expect(configWithoutPlugin.settings.get(['plugin'])).toEqual(['dummy']);
+});