Skip to content

Commit

Permalink
docs(aws-cloudwatch): Fix example for MathExpression (#22933)
Browse files Browse the repository at this point in the history
In the commit f37991c the example was changed to use a different metric to make it compile. Unfortunately the `id` for the metric was only updated in its use not in the definition.

This can be a bit confusing when reading the example for the first time and if used as is it would not result in the intended behavior. Therefore I updated the example.

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
dreuter authored Nov 17, 2022
1 parent bb28823 commit 97e3c59
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-cloudwatch/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ const allProblems = new cloudwatch.MathExpression({
expression: "errors + throttles",
usingMetrics: {
errors: fn.metricErrors(),
faults: fn.metricThrottles(),
throttles: fn.metricThrottles(),
}
});
```
Expand Down

0 comments on commit 97e3c59

Please sign in to comment.