Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(ecs): adding a circuit breaker causes Service replacement (under …
…feature flag) (#22467) Fixes #16126 Copied from #16919 with review comments as it went stale and closed. Initial implementation #22328 reverted because it was not backward compatible. Introduces feature flag: * `@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker` Enable this feature flag to avoid setting the "ECS" deployment controller when adding a circuit breaker to an ECS Service, as this will trigger a full replacement which fails to deploy when using set service names. This does not change any behaviour as the default deployment controller when it is not defined is ECS. _cdk.json_ ```json { "context": { "@aws-cdk/aws-ecs:disableExplicitDeploymentControllerForCircuitBreaker": true } } ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information