Skip to content

Commit 6de792c

Browse files
author
Niranjan Jayakar
authored
chore: fix github actions name and dependencies (#12919)
Github actions for v2 are failing because of a dependency definition on an incorrect name. See [failures]. Further, the dependency is incorrect. The 'auto-approve' job needs to run on PRs besides forward merges. Fix Github action names and remove the incorrect dependency. [failures]: https://github.com/aws/aws-cdk/actions/runs/547681911
1 parent 0f718b2 commit 6de792c

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

.github/workflows/v2-pull-request.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,7 @@ on:
1515

1616
jobs:
1717
# Run yarn pkglint on merge forward PRs and commit the results
18-
checkout:
19-
name: pkglint
18+
pkglint:
2019
if: contains(github.event.pull_request.labels.*.name, 'pr/forward-merge')
2120
runs-on: ubuntu-latest
2221
steps:
@@ -36,9 +35,7 @@ jobs:
3635

3736
# Approve automated PRs
3837
# Only approve! mergify takes care of the actual merge.
39-
approve:
40-
name: auto-approve
41-
needs: pkglint
38+
auto-approve:
4239
if: >
4340
github.event.pull_request.user.login == 'aws-cdk-automation'
4441
&& contains(github.event.pull_request.labels.*.name, 'pr/auto-approve')

0 commit comments

Comments
 (0)