chore: fix codecov workflow #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
commented
Feb 21, 2025
projenrc/codecov.ts
Outdated
| }); | ||
|
|
||
| this.workflow.addJob('collect', { | ||
| runsOn: ['ubuntu-latest'], |
Contributor
Author
There was a problem hiding this comment.
@mrgrain we should make this either required in projen or default to ubuntu-latest right
Contributor
There was a problem hiding this comment.
Huh. That might have changed tbh. But yes.
mrgrain
reviewed
Feb 21, 2025
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
Co-authored-by: Momo Kornher <[email protected]>
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
kaizencc
had a problem deploying
to
integ-approval
GitHub Actions
Failure
iankhou
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runs are currently failing because
runs-onis required: https://github.com/aws/aws-cdk-cli/actions/runs/13461282048By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license