generated from amazon-archives/__template_Apache-2.0
-
Notifications
You must be signed in to change notification settings - Fork 56
refactor(toolkit-lib): standardize confirmation requests to use ConfirmationRequest interface #904
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aws-cdk-automation
merged 2 commits into
main
from
mrgrain/refactor/toolkit-lib/standardize-confirmation-requests
Oct 6, 2025
Merged
refactor(toolkit-lib): standardize confirmation requests to use ConfirmationRequest interface #904
aws-cdk-automation
merged 2 commits into
main
from
mrgrain/refactor/toolkit-lib/standardize-confirmation-requests
Oct 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmationRequest interface - Convert CDK_TOOLKIT_I8910 from DataRequest to ConfirmationRequest for refactor confirmation - Replace promptly.confirm usage with standardized IO message system in destroy and deploy flows - Update askUserConfirmation to use ActionLessRequest<ConfirmationRequest> pattern - Remove deprecated markTesting function and TESTING variable - Update tests to use requestSpy instead of promptly mocks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 83.69% 82.95% -0.75%
==========================================
Files 65 65
Lines 9558 9546 -12
Branches 1135 1117 -18
==========================================
- Hits 8000 7919 -81
- Misses 1535 1605 +70
+ Partials 23 22 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Oct 6, 2025
iankhou
pushed a commit
that referenced
this pull request
Oct 7, 2025
…rmationRequest interface (#904) This PR standardizes user confirmation flows across the CDK CLI by migrating from ad-hoc `promptly.confirm` usage to the structured `ConfirmationRequest` interface. These are the changes as suggested here: #826 (review) ## Changes - **Convert CDK_TOOLKIT_I8910**: Changed from `DataRequest` to `ConfirmationRequest` for refactor confirmation - **Standardize destroy flow**: Replace `promptly.confirm` with `IO.CDK_TOOLKIT_I7010` message - **Standardize deploy flow**: Update `askUserConfirmation` to use `ActionLessRequest<ConfirmationRequest>` pattern - **Clean up test infrastructure**: Remove deprecated `markTesting` function and `TESTING` variable - **Update tests**: Replace `promptly` mocks with `requestSpy` for consistency ## Benefits - Consistent user interaction patterns across all CLI commands - Better testability through standardized mocking - Improved error handling and TTY detection through the IO system - Cleaner separation of concerns between UI logic and business logic --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR standardizes user confirmation flows across the CDK CLI by migrating from ad-hoc
promptly.confirmusage to the structuredConfirmationRequestinterface.These are the changes as suggested here: #826 (review)
Changes
DataRequesttoConfirmationRequestfor refactor confirmationpromptly.confirmwithIO.CDK_TOOLKIT_I7010messageaskUserConfirmationto useActionLessRequest<ConfirmationRequest>patternmarkTestingfunction andTESTINGvariablepromptlymocks withrequestSpyfor consistencyBenefits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license