chore: trigger transitive releases when packages update #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For packages that include other packages, like the CLI does, it should also include changes to bundled packages when looking at whether a release should be triggered. This includes `cloud-assembly-schema` and `cloudformation-diff` into the release trigger of the CLI and all packages that include the CLI. You'd think this could perhaps be done more declaratively, but I can't rely on storing information on the `TypeScriptWorkSpace` project (like "considered dependencies") because we need to pass this information to its constructor. So I'm just copy/pasting long arrays.
rix0rrr
had a problem deploying
to
integ-approval
GitHub Actions
Failure
mrgrain
had a problem deploying
to
integ-approval
GitHub Actions
Failure
auto-merge was automatically disabled
February 24, 2025 12:32
Pull request was closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #83 +/- ##
==========================================
+ Coverage 84.44% 85.06% +0.61%
==========================================
Files 196 196
Lines 35089 35089
Branches 4509 4578 +69
==========================================
+ Hits 29632 29847 +215
+ Misses 5320 5107 -213
+ Partials 137 135 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mrgrain
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For packages that include other packages, like the CLI does, it should also include changes to bundled packages when looking at whether a release should be triggered.
This includes
cloud-assembly-schemaandcloudformation-diffinto the release trigger of the CLI and all packages that include the CLI.You'd think this could perhaps be done more declaratively, but I can't rely on storing information on the
TypeScriptWorkSpaceproject (like "considered dependencies") because we need to pass this information to its constructor. So I'm just copy/pasting long arrays.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license